forked from jeremy/mysql2
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.3.x latin1 to utf8 with mariadbclient support #29
Open
lewispb
wants to merge
72
commits into
0.3.x_force_latin1_to_utf8
Choose a base branch
from
0.3.x_mariadbclient-support
base: 0.3.x_force_latin1_to_utf8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than use the MySQL specific TINYTEXT, MEDIUMTEXT and LONGTEXT datatypes, Active Record migrations use TEXT(n) where n is the limit specified by the developer. Unfortunately how MySQL interprets n depends on the column's encoding so any limit above 5592405 will be interpreted as a LONGTEXT. This commit fixes this by interpreting the limit within the adapter and using the specific MySQL datatype as appropriate.
…ing-to-longtext Backport of fix from rails/rails#5173
The backport of table_exists? expects tables to accept an arity of 2, whereas the version in the Mysql2Adapter only has an arity of 1. The second parameter provides for querying tables in databases other than the currently selected database. This commit fixes this by backporting the tables method from the MysqlAdapter in Rails 3.0.x.
Fix backport of table_exists? in 14accdf
Support has moved to the em-synchrony gem.
…in, just hack the generated charset mapping to force mysql latin1 to ruby utf8
Unix systems using libtool do not need to do a version check against the client version string as the libraries themselves are versioned.
Only do version check in Windows environment
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-3.html#mysqld-8-0-3-capi > The deprecated secure_auth system variable and --secure-auth client option have been removed. > The MYSQL_SECURE_AUTH option for the mysql_options() C API function was removed.
MySQL 8.0 replaces my_bool with C99 bool. Earlier versions of MySQL had a typedef to char. Gem users reported failures on big endian systems when using C99 bool types with older MySQLs due to mismatched behavior.
Unix systems using libtool do not need to do a version check against the client version string as the libraries themselves are versioned.
libmariadb-client-lgpl-dev in newly released Debian stable (jessie) ships `/usr/bin/mariadb_config`.
See also makandra@56b46c8
* mariadbclient-support: (34 commits) Support microseconds Also search for mariadb_config on compile Fix for MariaDB 10.2 which does not define CLIENT_LONG_PASSWORD Only do version check in Windows environment Bump version to 0.2.24 Rather than keeping the CHARSET_MAP hack around, through thick and thin, just hack the generated charset mapping to force mysql latin1 to ruby utf8 Bump version to 0.2.23 (matching 0.3.16) bump version for 0.2.22 release bump for 0.2.21 release bump version for 0.2.20 release bump version for 0.2.19 release Remove EM/fiber support from this gem symbolize keys sooner bump version to 0.2.19b6 only use default limit value if offset is used without limit use local db config if avail active_record: Delegate BigDecimal quoting to abstract adapter. bump version for 0.2.19b4 release whitespace ensure connect_timeout is a positive integer ...
…lient-support * makandra/0.3.x-lts: Use a typedef my_bool to improve compatibility across MySQL versions MYSQL_SECURE_AUTH has been removed in MySQL 8.0.3 RC (brianmario#892) Only do version check in Windows environment Fix for MariaDB 10.2 which does not define CLIENT_LONG_PASSWORD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in patches from https://github.com/makandra/mysql2/tree/0.3.x-lts