Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the description of HTTP_READ_TIMEOUT and HTTP_WRITE_TIMEOUT in README is reversed. #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atolix
Copy link

@atolix atolix commented Aug 21, 2024

Fix README.
If I'm wrong, please close PR.

@hachi8833
Copy link

I also guess that the lines specified is something incorrect, and the following might be better:

HTTP_WRITE_TIMEOUT: The maximum time in seconds that the server can take to write the response to the client.

@tamaloa
Copy link

tamaloa commented Mar 4, 2025

I was also confused by the wording and my usual expectations configuring timeouts for client libraries (and also by the presence of this PR).

But the current documentation correctly describes timeouts from the perspective of this library.

For Thruster a write timeout determines how long it may write to a given client (which would be a read timeout from the clients perspective).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants