Use the target range to insert the replacement text #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the browser auto-corrects a misspelled word, it dispatches a `beforeinput` event with the `insertReplacementText` input type and a `dataTransfer` object containing the replacement text. The event also contains a `getTargetRanges` method that returns an array of `DOMRange` objects representing the range of text that will be replaced. When the `Level2InputController` was originally implemented, not all browsers supported the `getTargetRanges` method, so it was not used. Now that all supported browsers do support `getTargetRanges`, we can use it to insert the replacement text at the correct location. This ensures editor state is updated correctly the cursor is positioned correctly. Ref. - https://w3c.github.io/input-events/#overview (search for "insertReplacementText") - https://developer.mozilla.org/en-US/docs/Web/API/InputEvent/getTargetRanges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the browser auto-corrects a misspelled word, it dispatches a
beforeinputevent with theinsertReplacementTextinput type and adataTransferobject containing the replacement text. The event also contains agetTargetRangesmethod that returns an array ofDOMRangeobjects representing the range of text that will be replaced.When the
Level2InputControllerwas originally implemented, not all browsers supported thegetTargetRangesmethod, so it was not used.Now that all supported browsers do support
getTargetRanges, we can use it to insert the replacement text at the correct location. This ensures editor state is updated correctly the cursor is positioned correctly.Ref.