refactor/builders #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elds and improve error handling
…exception handling
…o use toArray method for request serialization
…quest and update related classes
…erTest for improved request validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored multiple request builders (
CreatePixQrCodeRequestBuilder,CreateBillingRequestBuilder) to correctly handle optional and required fields according to the API specification.Improved validation logic inside builders, using
AbacatePayException::missingRequiredFields()for consistent error reporting.Updated
CreatePixQrCodeRequestto support optional fields (expiresIn,description,customer,metadata) and improvedmake()method to safely handle partial payloads.Added comprehensive unit tests for
CreatePixQrCodeRequestBuilderandCreateBillingRequestBuildercovering:Ensured all builders follow a fluent and validated construction pattern, aligning with SDK design standards.
This PR enhances reliability, consistency, and test coverage across all request builders.