Update submodule to fix build in humble #253
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
image_common
submodule currently points to a commit on thejazzy
branch, which does not work withhumble
:When checking out the
image_common
submodule at commitb17b272
, the build of thecamera_calibration_parsers
package fails:This issue was reported in #250 but then fixed on the
image_common
side. This solution does not work because we use this repo as a submodule and do not want to modify the files down the line.This PR updates the submodule to the current hash of the
humble
branch, which fixes the build. This is also the branch specified in the known issue section here.In general, I agree with #247 that having the
image_common
as a submodule is not a good idea. In our case, we also had theimage_common
package already in our workspace, which made the build fail.