Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule to fix build in humble #253

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

benemer
Copy link

@benemer benemer commented Nov 6, 2024

The image_common submodule currently points to a commit on the jazzy branch, which does not work with humble:

When checking out the image_common submodule at commit b17b272, the build of the camera_calibration_parsers package fails:

Starting >>> image_transport
--- stderr: camera_calibration_parsers               
CMake Error at CMakeLists.txt:23 (add_library):
CMake Error at CMakeLists.txt:23 (add_library):
  Target "camera_calibration_parsers" links to target "yaml-cpp::yaml-cpp"
  but the target was not found.  Perhaps a find_package() call is missing for
  an IMPORTED target, or an ALIAS target is missing?

This issue was reported in #250 but then fixed on the image_common side. This solution does not work because we use this repo as a submodule and do not want to modify the files down the line.

This PR updates the submodule to the current hash of the humble branch, which fixes the build. This is also the branch specified in the known issue section here.

In general, I agree with #247 that having the image_common as a submodule is not a good idea. In our case, we also had the image_common package already in our workspace, which made the build fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant