Move slider translations from generated /locales to source /.homeycompose/locales #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: basmilius <978257+basmilius@users.noreply.github.com>
Co-authored-by: basmilius <978257+basmilius@users.noreply.github.com>
Co-authored-by: basmilius <978257+basmilius@users.noreply.github.com>
Co-authored-by: basmilius <978257+basmilius@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Revise sliders feature to set colors and icons from app settings
Migrate sliders to centralized looks system
Feb 10, 2026
Co-authored-by: basmilius <978257+basmilius@users.noreply.github.com>
Copilot
AI
changed the title
Migrate sliders to centralized looks system
Move slider translations from generated /locales to source /.homeycompose/locales
Feb 10, 2026
Owner
|
@copilot The changes in the /locales directory were not reverted, please revert. |
Co-authored-by: basmilius <978257+basmilius@users.noreply.github.com>
Contributor
Author
basmilius
reviewed
Feb 10, 2026
src/brain/sliders.ts
Outdated
| } | ||
|
|
||
| async getLook(name: string): Promise<Look> { | ||
| return this.looks[name] ?? ['#204ef6', '']; |
Owner
There was a problem hiding this comment.
Use the symbol as fallback icon.
Contributor
Author
There was a problem hiding this comment.
Added in commit c9dbc56. Using Unicode U+F1DE (Font Awesome sliders icon) as the fallback icon.
basmilius
reviewed
Feb 10, 2026
widgets/slider/public/index.html
Outdated
| slider.style.setProperty('--slider-icon', JSON.stringify(icon)); | ||
| slider.style.setProperty('--slider-icon-secondary', JSON.stringify(icon + icon)); | ||
| const color = sliderData.color || '#204ef6'; | ||
| const icon = sliderData.icon || ''; |
Owner
There was a problem hiding this comment.
Can we fallback to the original widget settings?
Contributor
Author
There was a problem hiding this comment.
Added in commit c9dbc56. The widget now attempts to load from app settings first, and if that fails, falls back to the original widget settings (settings.color and settings.icon.unicode) if they exist.
Owner
|
@copilot Look at the review comments. |
Co-authored-by: basmilius <978257+basmilius@users.noreply.github.com>
Contributor
Author
Addressed both review comments in commit c9dbc56:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Move Slider Translations to Correct Location ✅
The translations were incorrectly added to
/locales(generated directory) instead of/.homeycompose/locales(source directory).Completed Changes:
/localesdirectory (13 locale files) - now completely untouched from base/.homeycompose/localesdirectory (13 locale files)getLook()methodSummary
✅ All translations are now in the correct location:
/localesto their EXACT original state/.homeycompose/localeswith proper positioning (after "sets", before "timers")getLook()method/localesdirectory will be regenerated from/.homeycomposeby Homey's build processChanges in this PR:
Backend: Implement looks system for sliders with app settings
Frontend: Add sliders category to settings UI
Widget: Update to fetch color/icon from app settings with fallback to widget settings
Locales: ✅ Translations properly placed in
/.homeycompose/locales(source),/locales(generated) is untouched💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.