Register service actions in async_setup for Bronze tier compliance #1403
Conversation
|
Awesome! Thanks for all the PRs. There seems to be one failing job still (pre-commit). |
ademuri
force-pushed
the
bronze-action-setup
branch
3 times, most recently
from
999fda6 to
0020cdd
Compare
|
@all-contributors please add @ademuri for code |
|
I've put up a pull request to add @ademuri! 🎉 |
|
Thanks for working on this! Python 3.12 type syntaxThe change from |
| type AdaptiveSwitches = list[AdaptiveSwitch] | ||
| type AdaptiveSwitchMap = dict[AdaptiveSwitch, list[str]] |
There was a problem hiding this comment.
This was a result of running ruff check . --fix. Looks like the Ruff target Python version is currently set to 3.10.
I ran Ruff because Home Assistant core requires it, but I don't see it in either of the READMEs. Should it be used?
There was a problem hiding this comment.
I reverted this change.
README.md
Outdated
| | `entity_id` | The `entity_id` of the switch with the settings to apply. 📝 | ✅ | list of `entity_id`s | | ||
| | `lights` | A light (or list of lights) to apply the settings to. 💡 | ❌ | list of `entity_id`s | | ||
| | `transition` | Duration of transition when lights change, in seconds. 🕑 | ❌ | `float` 0-6553 | | ||
| | `transition` | Duration of transition when lights change, in seconds. 🕑 | ✅ | `float` 0-6553 | |
There was a problem hiding this comment.
Why did you make it a required attribute?
There was a problem hiding this comment.
This was unintentional, I think related to initial_transition not being present for apply_service_schema. The default is now None in the schema - will that cause any issues?
- Move 'apply' and 'set_manual_control' service registration from async_setup_entry to async_setup. - Move service handlers to module-level functions in switch.py. - Update apply_service_schema to support dynamic defaults for transition duration. - Clean up related unused imports and fix Python 3.10 syntax compatibility.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ademuri
force-pushed
the
bronze-action-setup
branch
from
0020cdd to
d3190be
Compare
ademuri
force-pushed
the
bronze-action-setup
branch
from
d3190be to
9c3f4ab
Compare
2 participants
Addresses a point from #1195.