Test that switch is on before updating time listeners #936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
adaptive_lighting.change_switch_settings
while the lights are off will cause the below errors to appear in your HA logs:These errors appear about every 90 seconds, I assume more or less depending on the set transition time.
It appears this is because the function
handle_change_switch_settings
will always make a call to_update_time_interval_listener
, even when the switch is off.This PR just adds a single line to check if the switch is on before calling the above function.