Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some aria fixes #34

Merged
merged 2 commits into from
Dec 8, 2023
Merged

some aria fixes #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be6ba96
some aria fixes
batistaDev1113 Dec 8, 2023
a2c53fb
fixed linkedin broken link
batistaDev1113 Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions components/FooterComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ import { Footer } from "flowbite-react";
import { BsGithub, BsLinkedin } from "react-icons/bs";
import { RxCodesandboxLogo } from "react-icons/rx";

const LINKEDIN_URL = "https://www.linkedin.com/in/yunior-profile/";
const GITHUB_URL = "https://github.com/batistaDev1113";

const FooterComponent = () => {
return (
<Footer
Expand All @@ -16,16 +19,23 @@ const FooterComponent = () => {
<Footer.Copyright href='#' by='Yunior Batista' year={2023} />
<div className='flex space-x-4 ml-8'>
<Footer.Icon
href='https://www.linkedin.com/in/yunior-batista-profile/'
href={LINKEDIN_URL}
target='_blank'
icon={BsLinkedin}
aria-label="Link to Yunior's LinkedIn profile"
/>
<Footer.Icon
href='https://github.com/batistaDev1113'
href={GITHUB_URL}
target='_blank'
icon={BsGithub}
aria-label="Link to Yunior's GitHub profile"
/>
<Footer.Icon
href='#'
target='_blank'
icon={RxCodesandboxLogo}
aria-label="Link to Yunior's codesandbox profile"
/>
<Footer.Icon href='#' target='_blank' icon={RxCodesandboxLogo} />
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions components/Hero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const Hero = () => {
<section className='grid grid-cols-1 md:grid-cols-2 grid-rows-2 md:grid-rows-1 gap-3 grid-flow-col'>
<Link
href='/Yunior_Batista_Resume.pdf'
aria-label='Resume'
aria-label='View Resume'
locale={false}
className='button-about'
target='_blank'
Expand All @@ -94,7 +94,7 @@ const Hero = () => {
</Link>
<Link
href='/Yunior_Batista_Resume.pdf'
aria-label='Download my CV'
aria-label='Download Resume'
locale={false}
download='/Yunior_Batista_Resume.pdf'
className='button-about'
Expand Down
12 changes: 10 additions & 2 deletions components/Navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,20 @@ const Navigation = () => {
<Navbar.Toggle />
</div>
<Navbar.Collapse className='uppercase'>
<Navbar.Link href='#projects' role='navigation'>
<Navbar.Link
href='#projects'
role='link'
aria-label='Link to projects section'
>
<span className='pb-1 hover:text-teal-600 dark:hover:text-teal-300 hover:border-b-2 hover:border-indigo-500 hover:border-spacing-4'>
Some Projects I&apos;ve Built
</span>
</Navbar.Link>
<Navbar.Link href='#contact' role='navigation'>
<Navbar.Link
href='#contact'
role='link'
aria-label='Link to contact me form'
>
<span className='pb-1 hover:text-teal-600 dark:hover:text-teal-300 hover:border-b-2 hover:border-indigo-500 hover:border-spacing-4'>
Contact Me
</span>
Expand Down
4 changes: 2 additions & 2 deletions components/Project.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ const Project = ({ project }: ProjectProps) => {
fetchPriority='low'
/>
<div className='p-6 md:h-60 h-70 flex flex-col justify-around'>
<h5 className='text-2xl font-bold tracking-tight text-gray-900 dark:text-white'>
<h4 className='text-2xl font-bold tracking-tight text-gray-900 dark:text-white'>
{name}
</h5>
</h4>
<p className='font-normal text-gray-700 dark:text-gray-400 mt-5 mb-5'>
{description}
</p>
Expand Down