Api Cleanup (#664)

Use functions for api, not static class methods 👍
battlecode · Oct 3, 2023 · 42cfbd8 · 42cfbd8
1 parent cc86743
commit 42cfbd8
Show file tree

Hide file tree

Showing 7 changed files with 728 additions and 720 deletions.
diff --git a/frontend2/.eslintrc.js b/frontend2/.eslintrc.js
@@ -18,7 +18,7 @@ module.exports = {
     "*.json",
     ".eslintrc.js",
     "tailwind.config.js",
-    "**/types/**",
+    "src/utils/types",
   ],
   parserOptions: {
     project: "tsconfig.json",
@@ -28,7 +28,6 @@ module.exports = {
   },
   plugins: ["react"],
   rules: {
-    indent: ["error", 2],
     semi: ["error", "always"], // require semicolons ending statements
   },
   settings: {

diff --git a/frontend2/.prettierignore b/frontend2/.prettierignore
@@ -7,6 +7,9 @@
 # production
 /build
 
+# auto-generated type
+src/utils/types
+
 /coverage
 
 package-lock.json
diff --git a/frontend2/src/components/BattlecodeTable.tsx b/frontend2/src/components/BattlecodeTable.tsx
@@ -49,15 +49,15 @@ function BattlecodeTable<T>({
                 className={
                   idx % 2 === 0
                     ? `bg-white border-b ${
-                      onRowClick !== undefined
-                        ? "cursor-pointer hover:bg-gray-100 hover:text-gray-700"
-                        : ""
-                    }}`
+                        onRowClick !== undefined
+                          ? "cursor-pointer hover:bg-gray-100 hover:text-gray-700"
+                          : ""
+                      }}`
                     : `bg-gray-50 border-b ${
-                      onRowClick !== undefined
-                        ? "cursor-pointer hover:bg-gray-100 hover:text-gray-700"
-                        : ""
-                    }`
+                        onRowClick !== undefined
+                          ? "cursor-pointer hover:bg-gray-100 hover:text-gray-700"
+                          : ""
+                      }`
                 }
               >
                 {columns.map((col, idx) => (

diff --git a/frontend2/src/components/elements/Button.tsx b/frontend2/src/components/elements/Button.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+import React from "react";
 
 interface ButtonProps extends React.ComponentPropsWithoutRef<"button"> {
   variant?: string;
@@ -7,12 +7,10 @@ interface ButtonProps extends React.ComponentPropsWithoutRef<"button"> {
 
 const variants: Record<string, string> = {
   "": "bg-gray-50 text-gray-900 hover:bg-gray-100 ring-gray-300 ring-1 ring-inset",
-  "dark": "bg-gray-700 text-gray-50 hover:bg-gray-800"
+  dark: "bg-gray-700 text-gray-50 hover:bg-gray-800",
 };
 
-const Button: React.FC<ButtonProps> = (
-  { variant, label, ...rest }
-) => {
+const Button: React.FC<ButtonProps> = ({ variant, label, ...rest }) => {
   variant = variant ?? "";
   const variantStyle = variants[variant];
   return (