-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api/Auth #652
Api/Auth #652
Conversation
I thiiiink this is ready for review? Hopefully there's no random stuff in there lol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Left some comments and questions below.
one more ask: could you add rules to .prettierignore
and .eslintrc.js
to ignore the generated files?
afterwards, run npm run lint
(or npm run format
to automatically fix problems) and make sure that linting passes
frontend2/src/__test__/test_resources/battlecode_source_137.zip
Outdated
Show resolved
Hide resolved
It looks like merging this PR will overwrite/undo the later changes I made in the routing pr because of the merge. |
Oops! can I just merge frontend2 into my branch to fix this?? |
fixed the overwriting issues by changing the base branch around. looks good to merge now! |
drf-spectacular
.bat
scriptdrf-spectacular
Api.ts
class to replaceApi.js
from old frontendAuth.ts
class/auth function set for frontend authentication