Add routing #653
Add routing #653
Conversation
| export const EpisodeContext = createContext({ | ||
| // the default episode. | ||
| episode: DEFAULT_EPISODE, | ||
| setEpisode: (episode: string) => { |
There was a problem hiding this comment.
Q: should we standardize how we refer to the current episode? I have been calling it episodeId (referring to name_short like bc23) but I would be OK with using episode instead.
There was a problem hiding this comment.
We should def standardize this
What if we just call name_short episodeId and call name_long episodeName?
| import { EpisodeContext } from "../../../contexts/EpisodeContext"; | ||
| import { MemoryRouter } from "react-router-dom"; | ||
|
|
||
| test('should link to default episode', () => { |
There was a problem hiding this comment.
My tests are currently not working but when they are we will have dozens... thinking this may be a good opportunity to use the API/UI: <test message> (STABLE/UNSTABLE) format for test messages?
There was a problem hiding this comment.
| test('should link to default episode', () => { | |
| test('UI: should link to default episode', () => { |
There was a problem hiding this comment.
update after discussion: we won't include (stable/unstable), but we will include api/ui
|
addressed code review comments, let me know if this is good to merge! |
Looks good to me!! |
adds routing and
EpisodeContext. also adds stubs for a lot of pages