Add frontend lint / tests to ci workflow

[acrantel]

makes frontend2 tests / linting run on each pr.

[n8kim1]

so nice to have

[n8kim1]

do we ever plan on renaming frontend2 to frontend and then frontend to "old" or smth? if so, we'll have to make careful note to change this folder too, cuz it's not really a directory name in the same way in code as everything else

to be fair, i think that errors will expose this too

[j-mao]

See the working-directory key in the example here.

[j-mao]

GitHub workflow looks good to me! [modulo nit about using working-directory instead of cd blah &&] Thanks so much for doing this 🎉

do we ever plan on renaming frontend2 to frontend and then frontend to "old" or smth? if so, we'll have to make careful note to change this folder too, cuz it's not really a directory name in the same way in code as everything else

This can be done already, can't it? If I understand correctly this branch has zero dependency on the contents of frontend so the old stuff can be safely dropped and this directory renamed on the branch. Whenever you need to peek at old stuff, you can still find it in version control on main until this big feature branch gets merged.

[acrantel]

GitHub workflow looks good to me! [modulo nit about using working-directory instead of cd blah &&] Thanks so much for doing this 🎉

do we ever plan on renaming frontend2 to frontend and then frontend to "old" or smth? if so, we'll have to make careful note to change this folder too, cuz it's not really a directory name in the same way in code as everything else

This can be done already, can't it? If I understand correctly this branch has zero dependency on the contents of frontend so the old stuff can be safely dropped and this directory renamed on the branch. Whenever you need to peek at old stuff, you can still find it in version control on main until this big feature branch gets merged.

will put this into our roadmap

The base branch was changed.

[acrantel]

added a recommended plugin to eslint and required semicolons.