Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix team update/create bugs #671

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Fix team update/create bugs #671

merged 1 commit into from
Aug 24, 2023

Conversation

acrantel
Copy link
Member

@acrantel acrantel commented Aug 23, 2023 •
edited
Loading

Requesting that Jerry review this if possible because he most recently touched this code.

This PR fixes a bug that allows users to change what episode their team belongs to, and if their team has a report or not.

Testing:

  • Tested creating and updating a team locally.

@acrantel acrantel mentioned this pull request Aug 23, 2023
Merged
lowtorola
lowtorola approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@lowtorola lowtorola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I agree with potentially awaiting review from Jerry since he worked on this!

j-mao
j-mao approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@j-mao j-mao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me

@acrantel acrantel merged commit ceba37f into main Aug 24, 2023
2 checks passed
@acrantel acrantel deleted the serena/fix-team-update branch August 24, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-mao j-mao j-mao approved these changes

@lowtorola lowtorola lowtorola approved these changes

@apollo1291 apollo1291 Awaiting requested review from apollo1291

@n8kim1 n8kim1 Awaiting requested review from n8kim1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acrantel @j-mao @lowtorola