Rebuild Scrimmaging Page #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrantel
reviewed
Feb 2, 2024
| > | ||
| <span className={`${value === undefined ? "text-gray-400" : ""}`}> | ||
| <span> | ||
| {value === undefined ? placeholder : valueToLabel.get(value)} | ||
| </span> | ||
| <div |
There was a problem hiding this comment.
the little chevron on the select menu breaks b/c the select menu is nested in a dialog
tailwindlabs/headlessui#2524
I will push a fix for this (adding ui-not-open:rotate-0) to the div
There was a problem hiding this comment.
Ohh yeah that explains a lot... I nuked the styling on SelectMenu like writ large so feel free to change/fix it however lol
acrantel
force-pushed
the
scrimmaging-refactor
branch
from
8aabb18
to
fbde132
Compare
acrantel
force-pushed
the
scrimmaging-refactor
branch
from
1ddbba3
to
90e627b
Compare
acrantel
force-pushed
the
scrimmaging-refactor
branch
from
90e627b
to
aaa97ca
Compare
acrantel
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully rebuilt the scrimmaging page! It looks great and is fully functional 🎉