Team Profile page (for other teams) #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrantel
force-pushed
the
seren/general-ui
branch
from
6976b6b
to
139fa06
Compare
|
reminiscent of the quote and bio -- |
acrantel
force-pushed
the
seren/general-ui
branch
from
139fa06
to
c7cdece
Compare
lowtorola
approved these changes
May 11, 2024
, had one comment about page loading/success but if that's not a worry then all's good.| ) ?? [], | ||
| [episode, team], | ||
| ); | ||
| if (isNil(team.data)) { |
There was a problem hiding this comment.
Should this be if isNil && !isLoading? Or does this successfully still load until data is not returned?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #782