Replace goose CLI with ACP (Agent Client Protocol) #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add agent-client-protocol dependency for ACP communication - Create acp_client.rs module to handle ACP connections - Update analyze_diff to use ACP instead of shelling out to CLI - Run ACP session in dedicated thread with LocalSet (handles !Send futures) - Find goose via login shell to handle GUI apps not inheriting PATH - Update test binary to use async API
- Support both Goose (default) and Claude (claude-code-acp) agents - Add kill_on_drop(true) to ensure child processes are cleaned up on early exit - Each agent specifies its own ACP args (goose uses 'acp', claude runs in ACP mode by default)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the CLI-based AI integration (shelling out to
goose run -t) with proper ACP (Agent Client Protocol) communication. This provides a more robust and extensible foundation for AI features.Changes
agent-client-protocoldependency for ACP communicationacp_client.rsmodule to handle ACP connectionsclaude-code-acp) agentskill_on_drop(true)to ensure child processes are cleaned up on early exitWhy ACP?