Merged json-utils with jolt-core so there are no modularity issues #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was having the same package defined in two different jars, as that is disallowed in Java >=9 Instead of generating a jolt-core.jar artifact, jolt-core now generates jolt-core-all.jar Version has been changed to 0.2.0 to make the incompatibility explicit, as jars have changed.
|
For some reason, Travis is configured to try to run with Java 8 but the Install JDK just has 9 to 14 versions available, so... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to solve the issue of using Jolt with a version of Java > 9 with modularity.
As explained in #789 (Jolt and Java 9: split package) the fact that jolt generates two different jars that have classes in the same package and have to be used together is a problem when modularity rules are applied.
In any case, all the use cases I've seen of jolt do use both jar files... always. The alternative would be to move the classes in the json-utils package to a different package, but that would mean changing and recompiling the client code that uses jolt. As it is, one just needs to change the pom.xml to remove jolt-core and json-utils and replace them with jolt-core-all (changing the version).
Cheers!