-
-
Notifications
You must be signed in to change notification settings - Fork 630
feat(python): Support overriding from env vars for single_version_platform_override
#3295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(python): Support overriding from env vars for single_version_platform_override
#3295
Conversation
Summary of ChangesHello @meteorcloudy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the flexibility of Python toolchain configuration within Bzlmod by introducing the ability to override critical attributes like Python version, SHA256 checksum, strip prefix, and download URLs directly from environment variables. This change is crucial for maintaining compatibility with existing workflows, such as JAX's hermetic Python setups, ensuring a smooth transition to Bzlmod while providing external control over toolchain definitions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for overriding python_version
, sha256
, strip_prefix
, and urls
for single_version_platform_override
from environment variables. This is a useful feature for hermetic builds. The implementation is mostly solid, including refactoring to pass module_ctx
and updating tests to cover the new functionality. I've found one minor issue with how the url_env
variable is parsed, which could lead to empty strings in the URL list, and I've suggested a fix.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
9584347
to
84063fa
Compare
I'm pretty mixed on this. I'd like to talk in #3293 more to try and figure out how to glue things together better. As is, what this implies is all the APIs we have that accept some sort of version, url, etc, arg should have a Having |
python.defaults
'spython_version_env
attribute, we addpython_version_env
,sha256_env
,strip_prefix_env
,url_env
for corresponding attributes ofsingle_version_platform_override
, allowing reading those values from env vars.MINOR_MAPPING
from//python:versions.bzl
.This feature will make sure JAX's HERMETIC_PYTHON_* env vars keep working after migrating to Bzlmod.
https://docs.jax.dev/en/latest/developer.html#custom-hermetic-python-examples