Skip to content

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Sep 28, 2025

A followup to #3282 to finish up the cleanup and remove the unnecessary
starlark usage in naming.

@aignas aignas requested a review from rickeylev as a code owner September 28, 2025 02:18
Copy link
Contributor

Summary of Changes

Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request continues a cleanup effort by refactoring the naming conventions for re-exported Starlark symbols within the Python rules. The changes aim to improve code clarity and maintainability by removing redundant prefixes and simplifying the internal mechanism for exposing these symbols.

Highlights

  • Renamed Internal Starlark Symbols: The internal symbols used for re-exporting Bazel rules and providers (e.g., _starlark_py_binary, _starlark_PyInfo) have been renamed to remove the starlark prefix, resulting in cleaner names like _py_binary and _PyInfo.
  • Simplified Re-export Mechanism: The intermediate assignment step (e.g., _py_binary_impl = _starlark_py_binary) has been removed, allowing for direct usage of the renamed symbols, which streamlines the code and improves readability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a nice cleanup, removing the starlark prefix from symbol names and simplifying some of the logic by removing intermediate variables. The changes are clear and improve the codebase's consistency. I've added a few suggestions to further simplify the re-export pattern in some of the files, which I believe aligns with the goal of this refactoring.

@rickeylev rickeylev added this pull request to the merge queue Sep 28, 2025
Merged via the queue into bazel-contrib:main with commit 65f4c6e Sep 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants