Skip to content

Commit

Permalink
Set exec_group for apple_support_test
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 574385345
  • Loading branch information
kotlaja authored and swiple-rules-gardener committed Oct 18, 2023
1 parent ef7f259 commit c670a74
Showing 1 changed file with 13 additions and 8 deletions.
21 changes: 13 additions & 8 deletions test/apple_support_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,14 @@ def _apple_support_test_impl(ctx):
outputs = [run_output],
executable = test_tool,
arguments = [run_output.path],
toolchain = None,
exec_group = "mac_exec_group",
)
apple_support.run(
ctx,
outputs = [run_output_ctx],
executable = test_tool,
arguments = [run_output_ctx.path],
toolchain = None,
exec_group = "mac_exec_group",
)

platform_frameworks = apple_support.path_placeholders.platform_frameworks(
Expand All @@ -169,7 +169,7 @@ def _apple_support_test_impl(ctx):
"SDKROOT_PATH_ARG={}".format(apple_support.path_placeholders.sdkroot()),
],
xcode_path_resolve_level = apple_support.xcode_path_resolve_level.args,
toolchain = None,
exec_group = "mac_exec_group",
)
apple_support.run(
ctx,
Expand All @@ -182,7 +182,7 @@ def _apple_support_test_impl(ctx):
"SDKROOT_PATH_ARG={}".format(apple_support.path_placeholders.sdkroot()),
],
xcode_path_resolve_level = apple_support.xcode_path_resolve_level.args,
toolchain = None,
exec_group = "mac_exec_group",
)

action_args = ctx.actions.args()
Expand All @@ -209,7 +209,7 @@ def _apple_support_test_impl(ctx):
action_args,
],
xcode_path_resolve_level = apple_support.xcode_path_resolve_level.args_and_files,
toolchain = None,
exec_group = "mac_exec_group",
)
apple_support.run(
ctx,
Expand All @@ -220,7 +220,7 @@ def _apple_support_test_impl(ctx):
action_args,
],
xcode_path_resolve_level = apple_support.xcode_path_resolve_level.args_and_files,
toolchain = None,
exec_group = "mac_exec_group",
)

apple_support.run_shell(
Expand All @@ -233,7 +233,7 @@ def _apple_support_test_impl(ctx):
output = run_shell_output.path,
tool = test_tool.path,
)],
toolchain = None,
exec_group = "mac_exec_group",
)
apple_support.run_shell(
ctx,
Expand All @@ -243,7 +243,7 @@ def _apple_support_test_impl(ctx):
output = run_shell_output_ctx.path,
tool = test_tool.path,
)],
toolchain = None,
exec_group = "mac_exec_group",
)

test_files = [
Expand Down Expand Up @@ -287,5 +287,10 @@ apple_support_test = rule(
implementation = _apple_support_test_impl,
attrs = apple_support.action_required_attrs(),
fragments = ["apple"],
exec_groups = {
"mac_exec_group": exec_group(
exec_compatible_with = ["@platforms//os:macos"],
),
},
test = True,
)

1 comment on commit c670a74

@keith
Copy link
Member

@keith keith commented on c670a74 Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not taking

Please sign in to comment.