Skip to content

Add emsdk@v5.0.1#7571

Closed
mmorel-35 wants to merge 1 commit intobazelbuild:mainfrom
mmorel-35:emsdk@v5.0.1
Closed

Add emsdk@v5.0.1#7571
mmorel-35 wants to merge 1 commit intobazelbuild:mainfrom
mmorel-35:emsdk@v5.0.1

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

@mmorel-35 mmorel-35 commented Feb 16, 2026

Description

Add emsdk@v5.0.1

@bazel-io
Copy link
Copy Markdown
Member

bazel-io commented Feb 16, 2026

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (emsdk) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Feb 16, 2026

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Feb 16, 2026
@mmorel-35 mmorel-35 force-pushed the emsdk@v5.0.1 branch 3 times, most recently from 883193a to 884f4d6 Compare February 16, 2026 18:57
@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Feb 16, 2026

/cc @sbc100

@mmorel-35 mmorel-35 marked this pull request as ready for review February 16, 2026 18:58
@sbc100
Copy link
Copy Markdown

sbc100 commented Feb 16, 2026

Does this have to happen for every emsdk release? Is is automatic?

@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Feb 16, 2026

It needs to be for each version indeed, this can be automated with https://github.com/bazel-contrib/publish-to-bcr/tree/main

mmorel-35
mmorel-35 commented Feb 16, 2026
View reviewed changes
modules/emsdk/metadata.json
Comment on lines 14 to +17
"4.0.13",
"4.0.15",
"4.0.16",
"4.0.17"
"4.0.17",
Copy link
Copy Markdown
Contributor Author

@mmorel-35 mmorel-35 Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbc100 ,
You'll find all the previous versions published in BCR

@sbc100
Copy link
Copy Markdown

sbc100 commented Feb 16, 2026

It needs to be for each version indeed, this can be automated with https://github.com/bazel-contrib/publish-to-bcr/tree/main

Great. I guess we should be doing this in our emsdk CI. Would you a have time to send a PR?

@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Feb 16, 2026

It is opened in emscripten-core/emsdk#1639

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Feb 17, 2026
@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Feb 17, 2026

@bazel-io skip_check incompatible_flags

@bazel-io bazel-io added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label Feb 17, 2026
@mmorel-35
Add emsdk@v5.0.1
986cc66 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Feb 17, 2026 •
edited
Loading

@sbc100 ,
I dropped macos and macos-arm since they fail. I believe this is related to the host python version on which emsdk relies, see
https://buildkite.com/bazel/bcr-presubmit/builds/28268/steps/canvas?sid=019c6cd1-96f8-45c3-8c68-cc3e72136876

It might worth looking at the hermetic python path

@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Feb 28, 2026

@meteorcloudy ,
Anything to do before merging this?

@meteorcloudy
Copy link
Copy Markdown
Member

meteorcloudy commented Mar 3, 2026

Sorry for the late response, a new version seems to be merged at #7636

@mmorel-35
Copy link
Copy Markdown
Contributor Author

mmorel-35 commented Mar 3, 2026

Alright, let's close this one so

@mmorel-35 mmorel-35 closed this Mar 3, 2026
@mmorel-35 mmorel-35 deleted the emsdk@v5.0.1 branch March 3, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmorel-35 @bazel-io @sbc100 @meteorcloudy