Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.2.0] Add no_toolchain_error to the platform rule. #25256

Open
bazel-io opened this issue Feb 11, 2025 · 6 comments
Open

[8.2.0] Add no_toolchain_error to the platform rule. #25256

bazel-io opened this issue Feb 11, 2025 · 6 comments
Assignees
@katre
Labels
soft-release-blocker Soft release blockers that are nice to have, but shouldn't block the release if it's the last one.
Milestone
8.2.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #25234
@bazel-io bazel-io added this to the 8.1.0 release blockers milestone Feb 11, 2025
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/skyframe/toolchains/PlatformKeys.java

cc: @bazelbuild/triage

@katre katre self-assigned this Feb 11, 2025
@katre
Copy link
Member

katre commented Feb 11, 2025

I'll try to cherrypick tomorrow.

@iancha1992 iancha1992 added the soft-release-blocker Soft release blockers that are nice to have, but shouldn't block the release if it's the last one. label Feb 11, 2025
@iancha1992
Copy link
Member

@katre is this a soft release blocker? We have already got the rc4 out for 8.1.0 just now.

@katre
Copy link
Member

katre commented Feb 12, 2025

It would be nice to include (Pigweed is excited about the idea). I'll try to get the CP done shortly.

@katre katre mentioned this issue Feb 12, 2025
Closed
@katre
Copy link
Member

katre commented Feb 12, 2025

Sent #25266 to merge this: it required a small code change but no major differences.

@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/skyframe/toolchains/PlatformKeys.java

cc: @bazelbuild/triage

@iancha1992 iancha1992 changed the title [8.1.0] Add no_toolchain_error to the platform rule. [8.2.0] Add no_toolchain_error to the platform rule. Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
soft-release-blocker Soft release blockers that are nice to have, but shouldn't block the release if it's the last one.
Projects
None yet
Milestone
8.2.0 release blockers
Development

No branches or pull requests
3 participants
@katre @bazel-io @iancha1992