[8.1.0] Add no_toolchain_error to the platform rule.
#25266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows platforms to provide custom error messages to users when no required toolchain can be found for a specific type (similar to the `toolchain_type.no_match_error` from b60a0f4). This should point to documentation or directions for users to properly use the platform. When this is set it replaces the previous message "For more information on platforms or toolchains see https://bazel.build/concepts/platforms-intro." RELNOTES: Add `missing_toolchain_error` to the `platform` rule, to customize error messages when a required toolchain type cannot be found for that platform. Closes bazelbuild#25234. PiperOrigin-RevId: 725775441 Change-Id: Ica00d215ad4ec8fb0edb714369e1d240d52c08f5
github-actions
bot
added
team-Configurability
iancha1992
approved these changes
Feb 12, 2025
iancha1992
changed the title
no_toolchain_error to the platform rule.no_toolchain_error to the platform rule.
|
@katre @gregestren Looks like this is not a regression in 8.1.0, so according our release policy, we won't create a new rc just for a non-regression bug fix. If we are creating another rc for other reason, I'm open to merge this one, otherwise let's postpone this to the next minor/patch release. Thank you! |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows platforms to provide custom error messages to users when no required toolchain can be found for a specific type (similar to the
toolchain_type.no_match_errorfrom b60a0f4).This should point to documentation or directions for users to properly use the platform.
When this is set it replaces the previous message "For more information on platforms or toolchains see https://bazel.build/concepts/platforms-intro."
RELNOTES: Add
missing_toolchain_errorto theplatformrule, to customize error messages when a required toolchain type cannot be found for that platform.Closes #25256.