-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: rules_docker failing on macOS #4173
Comments
What's going on with this? |
@mattmoor : Do you need more information? I was going to assign this bug to someone who maintains https://github.com/bazelbuild/rules_docker but I see you are one. :) |
I don't think this is rules_docker's fault. It was caused in-between commits to that repo, and coincided with the most recent release of bazel. If I go back to 0.7.0, it doesn't break the same way. |
This is also not MacOS-specific. |
Moreover I think this was one of the cherrypicks into 0.8, since I had put a travis build of a early testing release of 0.8-rc2 and it didn't have the same problem (bazelbuild/rules_docker#214 (comment)) |
https://travis-ci.org/bazelbuild/rules_docker/builds/299556420 is the run against the then-testing 0.8.0 release plus my changes that succeeded. |
@laszlocsomor As @Capstan indicates, this is almost certainly a Bazel 0.8 bug. If there is a workaround in @damienmg FYI |
@mattmoor As always, try to create a minimal reproducer fot this problem. |
@dslomov: Can you investigate and cherrypick a fix in 0.8.1? I saw the failure on the release candidate: https://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/bazel/job/release/328/Downstream_projects/ |
the commit where this started to fail in rules_docker is bazelbuild/rules_docker@2bfd21e |
repro is: git clone git@github.com:bazelbuild/rules_docker.git
cd rules_docker
bazel build //... |
(shameless plug) @iirina is the reviewer on the Groovy version of this PR, which needs love too :) |
Ugh, CI for What's the timeline on a fix? I'm guessing not the 0.9 RC since that cuts tomorrow... :( |
We will block cutting 0.9 RC on fixing this. |
Ftr we should do a patch release. Also we do test with head and we have the
breakage on ci too.
…On Thu, Nov 30, 2017, 10:52 PM Dmitry Lomov ***@***.***> wrote:
We will block cutting 0.9 RC on fixing this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4173 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADjHf5fLbx4PGOTxCN3bFaqxi7B6Vw9mks5s7yOmgaJpZM4QrsPF>
.
|
#4196 (see above) tracks a potential patch release. |
Thanks!
…On Fri, Dec 1, 2017 at 9:17 AM Dmitry Lomov ***@***.***> wrote:
#4196 <#4196> (see above)
tracks a potential patch release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4173 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADjHf0MQ34-l2WXSSaTOr9C8IhnvqYjsks5s77YrgaJpZM4QrsPF>
.
|
Hi, I'm working on a fix. I tried to reproduce the issue with my custom bazel but ran into another error:
Any thoughts how I can test that I fixed this with rules_docker? |
Hm. That looks like gflags/python-gflags#9, but like gflags self-hosed. Given this is pulling from bazel_tools (i.e., the bazel you've built), perhaps there's another issue recently introduced? (e.g., 8fd0f4a) |
Is there something tracking the gflags weirdness yet? (is it known outside of the |
Not that I know of. I will open a new bug about it now. |
Fixes #4173. RELNOTES: None. PiperOrigin-RevId: 177582228
thanks for getting this resolved! |
Fixes #4173. RELNOTES: None. PiperOrigin-RevId: 177582228
Fixes #4173. RELNOTES: None. PiperOrigin-RevId: 177582228
bazel-nightly's downstream project "rules_docker " is failing:
https://ci.bazel.io/job/Global/job/rules_docker/294/consoleFull
The text was updated successfully, but these errors were encountered: