refactor createSourceAction #22744
Closed
refactor createSourceAction #22744
+121
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Rules-CPP
Contributor
Author
|
cc @comius |
sgowroji
added
awaiting-user-response
PikachuHyA
force-pushed
the
refactor_createSourceAction
branch
from
4e03084 to
09ed307
Compare
Contributor
Author
Contributor
Author
PikachuHyA
force-pushed
the
refactor_createSourceAction
branch
2 times, most recently
from
58d0397 to
09eb1d9
Compare
Contributor
Author
Contributor
Author
|
cc @katre |
fmeum
added
awaiting-review
PikachuHyA
force-pushed
the
refactor_createSourceAction
branch
from
09eb1d9 to
b4396a4
Compare
github-actions
bot
removed
the
awaiting-review
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Jan 29, 2025
This patch refactors the C++ compilation actions in `CcCompilationHelper`. It introduces a helper method `createSourceActionHelper` to streamline the creation of source actions and reduces duplicated code related to PIC and non-PIC compilation.
## Changes
1. **Refactored Source Action Creation**:
- Introduced `createSourceActionHelper` to handle the common logic for creating compile actions.
- This method consolidates the setup and finalization of compile actions for both PIC and non-PIC variants.
- The helper method now handles setting up variables, creating temp actions, and registering the compile actions.
2. **Updated `createSourceAction` Method**:
- The `createSourceAction` method now calls `createSourceActionHelper` for both PIC and non-PIC compile actions.
- This change simplifies the `createSourceAction` method and removes redundancy.
## Background
I'm working on support C++20 Modules in Bazel, see bazelbuild#19940
While constructing the action graph for compiling C++20 Modules, I noticed that the `createSourceAction` code could be reused. Therefore, I refactored `createSourceAction`. One potentially unusual aspect is the handling of `ArtifactCategory.CPP_MODULE` at the end. Since the logic for handling C++20 Modules differs from that of Clang Modules, this part of the logic was placed outside of `createSourceActionHelper`.
the code of constructing the action graph for compiling C++20 Modules is bazelbuild#22553
Closes bazelbuild#22744.
PiperOrigin-RevId: 719290267
Change-Id: I62cd8826261866ce3bd4225c099a479288a449aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors the C++ compilation actions in
CcCompilationHelper. It introduces a helper methodcreateSourceActionHelperto streamline the creation of source actions and reduces duplicated code related to PIC and non-PIC compilation.Changes
Refactored Source Action Creation:
createSourceActionHelperto handle the common logic for creating compile actions.Updated
createSourceActionMethod:createSourceActionmethod now callscreateSourceActionHelperfor both PIC and non-PIC compile actions.createSourceActionmethod and removes redundancy.Background
I'm working on support C++20 Modules in Bazel, see #19940
While constructing the action graph for compiling C++20 Modules, I noticed that the
createSourceActioncode could be reused. Therefore, I refactoredcreateSourceAction. One potentially unusual aspect is the handling ofArtifactCategory.CPP_MODULEat the end. Since the logic for handling C++20 Modules differs from that of Clang Modules, this part of the logic was placed outside ofcreateSourceActionHelper.the code of constructing the action graph for compiling C++20 Modules is #22553