Feature/additional link outputs #25091
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Rules-CPP
sgowroji
added
awaiting-user-response
|
Hi @yuvalmo, Could you please take a look at the failing checks? |
|
@sgowroji it seems the failures are in the windows tests due to the first commit where I changed I will revert it later today. |
The feature allows for retrieving additional files created by the link command. The additional filenames are determined by the `cc_toolchain_config` attribute `additional_link_outputs` which lists the suffixes that will be added to the binary name. For binary `out` where `additional_link_outputs = [".a", ".b"]`, we'll expect the following files to be created by the link action: - `out` - `out.a` - `out.b` Solves bazelbuild#24990.
This only applies to windows, where the `.exe` suffix will be removed. This seems to me like a reasonable behaviour for windows devs.
yuvalmo
force-pushed
the
feature/additional-link-outputs
branch
from
56ac9e5 to
6da302d
Compare
|
@sgowroji Fixed now, all tests passed. |
sgowroji
added
awaiting-review
|
Can someone go over this PR? It is really critical to our project |
|
@pzembrod Would you be available to review this? It has the potential to squash many individual "I just need this one weird file my toolchain happens to produce" requests. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #24990.
Implement
additional_link_outputsfeature.The feature allows for retrieving additional files created by the link
command.
The additional filenames are determined by the
cc_toolchain_configattribute
additional_link_outputswhich lists the suffixes that willbe added to the binary name.
For binary
outwhereadditional_link_outputs = [".a", ".b"], we'llexpect the following files to be created by the link action:
outout.aout.brules_ccpull request with tests for the feature here.