Ensure that tests set up execution platforms for test rules #25142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for changes to the resolution of exec platforms for tests, have analysis tests register exec platforms that are compatible with their tests target platforms. In `target_compatible_with_test`, replace a usage of `sh_test` with `sh_binary` to retain the setup as closely as possible by avoiding changes to constraints and platforms. Also remove the remaining shell analysis tests now that shell rules have been moved out of the Bazel repo. Keeping them would require extensive mocking, at which point they would lose their purpose.
fmeum
requested review from
aranguyen and
katre
and removed request for
a team and
aranguyen
github-actions
bot
added
team-Configurability
comius
approved these changes
Jan 31, 2025
comius
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for changes to the resolution of exec platforms for tests, have analysis tests register exec platforms that are compatible with their tests' target platforms.
In
target_compatible_with_test, replace a usage ofsh_testwithsh_binaryto retain the setup as closely as possible by avoiding changes to constraints and platforms.Also remove the remaining shell analysis tests now that shell rules have been moved out of the Bazel repo. Keeping them would require extensive mocking, at which point they would lose their purpose.