[8.1.0] Set exit_code unconditionally on TestResult in BEP #25254
Conversation
Fixes bazelbuild#25165 I hope I did this right. I am able to see the output in my repro on rules_apple (which I can share if required by code review). Let me know if there's anything I've overlooked! It would be great to get this into 8.1.0 if possible. Closes bazelbuild#25203. PiperOrigin-RevId: 725718124 Change-Id: I9c845ce1dc18307f5932da972f4ad31058a42f89
bazel-io
added
team-Core
iancha1992
requested review from
michaeledgar
and removed request for
luispadron
|
@michaeledgar Let's wait and merge this for 8.2 unless this is a hard blocker. We're currently in the middle of releasing 8.1.0rc4. |
|
I can't comment on whether or not it's a hard blocker from a release standpoint, but as the submitter of the original PR, I'm in great need of the changes contained. The changes are small, tested, and fix a bug that impacts daily operations for us. I'll accept whatever outcome, but would greatly appreciate it if this cherry pick makes the cut. |
|
@aaronsky Looks like this is not a regression in 8.1.0, so according our release policy, we won't create a new rc just for a non-regression bug fix. If we make an exception this time, it'll be harder to refuse similar requests in future. And in theory the release could be delayed indefinitely because there will always be changes coming up that are important to users. But if we are creating another rc for other reason, I'm open to merge this one, otherwise let's postpone this to the next minor/patch release. |
|
New PR #25278. |
github-actions
bot
removed
the
awaiting-review
Fixes #25165
I hope I did this right. I am able to see the output in my repro on rules_apple (which I can share if required by code review). Let me know if there's anything I've overlooked!
It would be great to get this into 8.1.0 if possible.
Closes #25203.
PiperOrigin-RevId: 725718124
Change-Id: I9c845ce1dc18307f5932da972f4ad31058a42f89
Commit d5d9385