Skip to content

Commit

Permalink
fix: Small codegen libraries were removed from the Project Structure (#…
Browse files Browse the repository at this point in the history
…7042)

Partially related to #6547

The EmptyJarFilter is using a heuristic that is really not robust
https://github.com/bazelbuild/intellij/blob/3f81565b4aede217e160adc97a3f3b619bfa0498/java/src/com/google/idea/blaze/java/sync/importer/emptylibrary/EmptyLibraryFilter.java#L42-L50

Co-authored-by: Tomasz Pasternak <tomasz.pasternak@jetbrains.com>
  • Loading branch information
tpasternak and Tomasz Pasternak authored Dec 12, 2024
1 parent e1f2fe9 commit bb32225
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ static boolean isEnabled() {
return Arrays.stream(EmptyLibraryFilterSettings.EP_NAME.getExtensions())
.findFirst()
.map(EmptyLibraryFilterSettings::isEnabled)
.orElse(true);
.orElse(false);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@
import java.util.function.Predicate;
import java.util.stream.Collectors;
import javax.annotation.Nullable;

import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
Expand Down Expand Up @@ -1085,6 +1087,7 @@ public void testLibraryDependenciesWithJdepsButNoTarget() {
}

@Test
@Ignore // We disabled empty library exclusion and it is unclear if we will ever reenable it
public void testEmptyLibraryExcluded() {
ProjectView projectView =
ProjectView.builder()
Expand Down

0 comments on commit bb32225

Please sign in to comment.