Added a registry key to disable passing the extra compiler flags to Bazel when building a C/C++ target in debug mode. #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
product: CLion
tpasternak
suggested changes
Jun 5, 2023
clwb/src/META-INF/clwb.xml
Outdated
| @@ -28,6 +28,7 @@ | |||
| <moduleType id="BLAZE_CPP_MODULE" implementationClass="com.google.idea.blaze.clwb.BlazeCppModuleType"/> | |||
| <postStartupActivity implementation="com.google.idea.blaze.clwb.run.producers.NonBlazeProducerSuppressor"/> | |||
| <actionConfigurationCustomizer implementation="com.google.idea.blaze.plugin.ClwbHideMakeActions"/> | |||
| <registryKey defaultValue="false" description="Disable the extra debug flags in debug clang builds" key="bazel.clang.debug.extraflags.disabled"/> | |||
There was a problem hiding this comment.
This applies not only to clang builds, extraClangFlags variable contains only clang-specific flags, but extraDebugFlags applies to gdb, too
There was a problem hiding this comment.
Good point. I shall rename the registry key.
…azel when building a C/C++ target in debug mode.
tpasternak
approved these changes
Jun 5, 2023
but when we enable it, debugging breakpoints stop working. |
|
Well, indeed these flags are essential for paths lookup |
|
I don't want to give up debugging mode, I just don't want to have to recompile every time. |
|
@tpasternak hi. For example:
or .env file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #4113
Description of this change