Add 2024 support #5966
Closed
Add 2024 support #5966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedyarub
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: IntelliJ
sgowroji
added
awaiting-user-response
There are two breaking changes related to MockSdk that come in 2024.1: 1. It is impossible to add a non-JDK SDK to the JdkTable, so the test testChooseDifferentSdkIfCurrentNotJdk becomes useless and even more impossible to run, because it just fails at preparation phase. The related IntelliJ change is here: JetBrains/intellij-community@e8e8cf5#diff-76a3bd6e3df59635af359a63c0936b224dda2f0a80b42ba36236ee4fa85bc09bR55 2. The IdeaTestUtil.getMockJdk no longer returns an instance of MockJdk. It returns a regular JavaSdk instead. Even more, the MockSdk is officially deprecated. Hence, in 2024.1 and newer we need to Use the regular SDKs in tests and modify them with SdkModificator JetBrains/intellij-community@7f05dd0#diff-5fb6bb2bf3104221b2ee04a10cdcf4424ea108b3f541e6b7eb828c721ea8817fL183
…elbuild#5967) ExtensionPointImpl is now writen in Kotlin and extends Sequence instead of Iterable
There are two breaking changes related to MockSdk that come in 2024.1: 1. It is impossible to add a non-JDK SDK to the JdkTable, so the test testChooseDifferentSdkIfCurrentNotJdk becomes useless and even more impossible to run, because it just fails at preparation phase. The related IntelliJ change is here: JetBrains/intellij-community@e8e8cf5#diff-76a3bd6e3df59635af359a63c0936b224dda2f0a80b42ba36236ee4fa85bc09bR55 2. The IdeaTestUtil.getMockJdk no longer returns an instance of MockJdk. It returns a regular JavaSdk instead. Even more, the MockSdk is officially deprecated. Hence, in 2024.1 and newer we need to Use the regular SDKs in tests and modify them with SdkModificator JetBrains/intellij-community@7f05dd0#diff-5fb6bb2bf3104221b2ee04a10cdcf4424ea108b3f541e6b7eb828c721ea8817fL183
…llij into ay/2024.1_eap # Conflicts: # java/tests/integrationtests/com/google/idea/blaze/java/sync/projectstructure/JdksTest.java
There are two breaking changes related to MockSdk that come in 2024.1: 1. It is impossible to add a non-JDK SDK to the JdkTable, so the test testChooseDifferentSdkIfCurrentNotJdk becomes useless and even more impossible to run, because it just fails at preparation phase. The related IntelliJ change is here: JetBrains/intellij-community@e8e8cf5#diff-76a3bd6e3df59635af359a63c0936b224dda2f0a80b42ba36236ee4fa85bc09bR55 2. The IdeaTestUtil.getMockJdk no longer returns an instance of MockJdk. It returns a regular JavaSdk instead. Even more, the MockSdk is officially deprecated. Hence, in 2024.1 and newer we need to Use the regular SDKs in tests and modify them with SdkModificator JetBrains/intellij-community@7f05dd0#diff-5fb6bb2bf3104221b2ee04a10cdcf4424ea108b3f541e6b7eb828c721ea8817fL183
…llij into ay/2024.1_eap # Conflicts: # testing/BUILD
…llij into ay/2024.1_eap # Conflicts: # common/util/BUILD # intellij_platform_sdk/build_defs.bzl # java/BUILD # third_party/go/BUILD
…llij into ay/2024.1_eap # Conflicts: # intellij_platform_sdk/build_defs.bzl # java/BUILD # testing/testcompat/v241/com/google/idea/sdkcompat/BaseSdkTestCompat.java # third_party/go/BUILD
github-actions
bot
added
product: CLion
|
Let's just wait for @tpasternak to finish his PR |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: 5965
Description of this change
Enable 2024.1 EAP support.