Feature flags for resolve virtual includes using heuristics or clangd #6387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFrosch
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
LeFrosch
requested review from
ujohnny
and removed request for
jastice,
tpasternak,
agluszak and
mai93
github-actions
bot
added
product: CLion
ujohnny
requested changes
Apr 12, 2024
base/src/com/google/idea/blaze/base/sync/workspace/VirtualIncludesHandler.java
Show resolved
Hide resolved
base/src/com/google/idea/blaze/base/sync/workspace/VirtualIncludesHandler.java
Outdated
Show resolved
Hide resolved
ujohnny
reviewed
Apr 15, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #6375
Description of this change
Since using clangd (-ibazel) to resolve virtual includes only works with the legacy engine and currently breaks it under some circumstances (see #6375) revert back to the old heuristics based approach by default. To enable the usage of clangd the
bazel.sync.clangd.virtual.includeregistry flag can be set to true.