Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable bzlmod for"with_go_source" example #6404

Merged
merged 1 commit into from
May 6, 2024

Conversation

tpasternak
Copy link
Contributor

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

@github-actions github-actions bot added product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Apr 25, 2024
@mai93
Copy link
Collaborator

mai93 commented Apr 26, 2024

is the plugin failing to support bzlmod for this project?

@blorente
Copy link
Collaborator

blorente commented May 2, 2024

I think this is not a plugin issue, but rather a project issue. As it stands the project is not bzlmod-compatible (running bazel run //:gazelle fails). Maybe we can just disable bzlmod in the .bazelrc instead of the project file and make it compatible later

Copy link
Collaborator

@blorente blorente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock merging, but we definitely should either make the project bzlmod-compatible or move the flag to .bazelrc before merging.

@tpasternak
Copy link
Contributor Author

But it's only because we have --enable_bzlmod in the root .bazelrc

@tpasternak tpasternak merged commit cb6de7f into master May 6, 2024
10 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label May 6, 2024
@tpasternak tpasternak deleted the fix-with-go-source-example branch May 6, 2024 09:31
@tpasternak
Copy link
Contributor Author

oh, wait, I'm wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: GoLand GoLand plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants