Skip to content

Add Blaze User Setting for FastBuild Java Binary Path #6431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 6, 2024

Conversation

dtaveras
Copy link
Contributor

@dtaveras dtaveras commented May 15, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: https://github.com/bazelbuild/intellij/issues/6432

Description of this change

Add a user setting where the fastbuild binary path can be specified. I couldn't think of a way to programmatically derive it.

Screenshot 2024-05-15 at 1 47 01 PM

@dtaveras dtaveras changed the title Add Blazer User Setting for FastBuild Java Binary Path Add Blaze User Setting for FastBuild Java Binary Path May 15, 2024
@mai93
Copy link
Collaborator

mai93 commented May 21, 2024

Thanks @dtaveras! added a small comment otherwise LGTM

@mai93 mai93 self-assigned this May 21, 2024
@dtaveras dtaveras marked this pull request as ready for review June 6, 2024 01:48
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Jun 6, 2024
@mai93 mai93 merged commit 82e447d into bazelbuild:master Jun 6, 2024
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants