Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing directories when view_project_root is on #6493

Merged

Conversation

tpasternak
Copy link
Contributor

closes #6492

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

@tpasternak
Copy link
Contributor Author

It seems that there's no way way to test it well, as the code relies on file.listFiles()

@tpasternak tpasternak marked this pull request as ready for review June 18, 2024 16:04
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Jun 18, 2024
@tpasternak tpasternak force-pushed the fix-missing-directories-when-vpr-is-on branch from a985666 to f307512 Compare June 18, 2024 16:23
@mai93 mai93 merged commit f6bcaa9 into bazelbuild:master Jun 18, 2024
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Jun 18, 2024
@tpasternak tpasternak deleted the fix-missing-directories-when-vpr-is-on branch June 18, 2024 17:15
@jdai8
Copy link
Contributor

jdai8 commented Jun 19, 2024

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

view_project_root causes sub-directories to be excluded
4 participants