Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added swift_module param in partials to use it in xibs, storyboards a…
…nd datamodels compilation (#2335) **What has changed❓** In this PR I added `swift_module` as new param to partials, so it could be used to compile xibs, storyboards, datamodels, etc. **Why this is needed❓** I faced with a problem when tried to build 2 different targets with same `module_name` and when using `precompiled_apple_resource_bundle` rule. [rules_apple](https://github.com/bazelbuild/rules_apple) fail because of conflicting actions when creating `Info.plist-root-control` file under same path: `/Path/ModuleName-intermediates/Info.plist-root.control` After this change will be merged, I'm going to create second PR to remove `fake_rule_label` [from precompiled_apple_resource_bundle](https://github.com/bazel-ios/rules_ios/blob/789a8625a44d62f51fb733d98470d7fea9428358/rules/precompiled_apple_resource_bundle.bzl#L53) and plist files will be stored at: `/Path/TargetName-intermediates/Info.plist-root.control` but the resources are going to be compiled with proper `module_name`. **Other notes 📓** Right now [fake_rule_label](https://github.com/bazel-ios/rules_ios/blob/789a8625a44d62f51fb733d98470d7fea9428358/rules/precompiled_apple_resource_bundle.bzl#L53) is used there as `module_name`. I think this was a workaround and it would be good to remove it finally 🙏 --------- Co-authored-by: Timur Mustafaev <timur.mustafaev@revolut.com>
- Loading branch information