Add swiftinterface_imports to apple_static_xcframework_import #2328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this static xcframeworks which have a swiftinterface file will fail to compile when sandboxing is enabled since their swiftinterface won't be copied to the xcframework bundle. This changed in #2266 which was mirroring the swiftmodule_imports behavior that I believe is also wrong so I fixed that here too.
keith
requested review from
BalestraPatrick,
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
thii
approved these changes
Nov 16, 2023
keith
deleted the
ks/add-swiftinterface_imports-to-apple_static_xcframework_import
branch
|
We will need tests to prevent future regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this static xcframeworks which have a swiftinterface file will
fail to compile when sandboxing is enabled since their swiftinterface
won't be copied to the xcframework bundle.
This changed in #2266
which was mirroring the swiftmodule_imports behavior that I believe is
also wrong so I fixed that here too.