fix: feature sanity check in rule based toolchains #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasoyen
requested review from
trybka,
armandomontanez,
pzembrod,
comius and
c-mita
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This check ensures feature names are not duplicated. It does this by collecting all features. Including those from capabilities from tools from the `tool_map`. If we now annotate a `gcc` tool with `@rules_cc//cc/toolchains/capabilities:supports_pic` and that tool is used for `c_compile_actions`, `cpp_compile_actions` and `link_actions`, the capability is collected multiple times and so is the feature. If we extend the test here, we exclude the override check on the same feature.
|
Alternative #344 |
|
#344 has merged, so closing this one. |
|
Oops, GC'd a little too early. |
|
Solved another way in 4d4fc07 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check ensures feature names are not duplicated. It does this by collecting all features. Including those from capabilities from tools from the
tool_map.If we now annotate a
gcctool with@rules_cc//cc/toolchains/capabilities:supports_picand that tool is used forc_compile_actions,cpp_compile_actionsandlink_actions, the capability is collected multiple times and so is the feature.If we extend the test here, we exclude the override check on the same feature.