Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate capability features #344

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deduplicate capability features #344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cc/toolchains/impl/toolchain_config_info.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def _validate_feature(self, known_features, fail):
def _validate_toolchain(self, fail = fail):
capabilities = []
for tool in self.tool_map.configs.values():
capabilities.extend([cap.feature for cap in tool.capabilities])
capabilities.extend([cap.feature for cap in tool.capabilities if cap.feature not in capabilities])
comius marked this conversation as resolved.
Show resolved Hide resolved
known_features = _get_known_features(self.features, capabilities, fail = fail)

for feature in self.features:
Expand Down