Make rule-based toolchain providers publicly available #540
+1
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to implement bazelbuild#517 For details see bazelbuild#525
limdor
requested review from
armandomontanez,
c-mita,
comius,
hvadehra,
pzembrod and
trybka
as code owners
Contributor
Author
|
@trybka @armandomontanez @pzembrod @c-mita @hvadehra could some of you provide some initial feedback? Do you think this is something that could happen or do we need to find another alternative? |
Collaborator
|
The only one I'm not confident about exposing is I'm generally onboard with this idea because of the work it will unlock--it was one of my original goals to expose these after we were confident this ruleset had stabilized. |
Contributor
Author
|
I will close the PR then, I will find another way to expose only the necessary symbols. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to implement #517
For details see #525