cc_toolchain's tool_map should be cfg-exec-configured #555
+236
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
requested review from
armandomontanez,
c-mita,
comius,
hvadehra,
pzembrod and
trybka
as code owners
dzbarsky
force-pushed
the
zbarsky/tool_map
branch
15 times, most recently
from
ca23f76 to
a91a95d
Compare
dzbarsky
force-pushed
the
zbarsky/tool_map
branch
7 times, most recently
from
63ff83e to
cc175a4
Compare
dzbarsky
force-pushed
the
zbarsky/tool_map
branch
4 times, most recently
from
0ac92cf to
ad72f0e
Compare
Collaborator
armandomontanez
left a comment
armandomontanez
left a comment
There was a problem hiding this comment.
Thanks for putting this together! I'll try to take a closer look early next week. If I don't get back to you in a timely manner, please ping me with a comment here.
dzbarsky
force-pushed
the
zbarsky/tool_map
branch
3 times, most recently
from
21a6ab9 to
79f0585
Compare
dzbarsky
force-pushed
the
zbarsky/tool_map
branch
from
79f0585 to
2574ba4
Compare
Contributor
Author
@armandomontanez PTAL :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However, it's not enough for
tool_mapto be oncc_toolchain_config- it must be on the toolchain itself to properly share the same exec platform as the action requesting the toolchain. Therefore we rearrange the implementation of thecc_toolchainmacro to pass it to the rule, and teach the rule to accept it from either the attribute or thecc_toolchain_config.Eventually,cc_toolchain_configcan be retired, though it will be a long journey.