Skip to content

Ensure the library search path from cc_toolchain is preferred over whatever rustc finds in the Windows registry #3608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

Ensure the library search path from cc_toolchain is preferred over whatever rustc finds in the Windows registry #3608

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5743087
Fix #3256: ensure the library search path from cc_toolchain is prefer…
dgrunwald-qt Sep 11, 2025
44a4e0c
Merge branch 'main' into fix-3256
illicitonion Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions rust/private/rustc.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,17 @@ def get_linker_and_args(ctx, crate_type, cc_toolchain, feature_configuration, rp
feature_configuration = feature_configuration,
action_name = action_name,
)
if "LIB" in link_env:
# Needed to ensure that link.exe will use msvcrt.lib from the cc_toolchain,
# and not a non-hermetic system version.
# https://github.com/bazelbuild/rules_rust/issues/3256
# I don't see a good way to stop rustc from adding the non-hermetic library search path,
# so put our cc_toolchain library search path on the command line where it has
# precedence over the non-hermetic path injected by rustc.
link_args = link_args + [
"-LIBPATH:" + element
for element in link_env["LIB"].split(";")
]

return ld, link_args, link_env

Expand Down