Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: complete the Windows CI coverage #1295

Closed
wants to merge 14 commits into from
Closed

CI: complete the Windows CI coverage #1295

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
dcbcccc
CI: complete the Windows CI coverage
Steelskin Aug 7, 2024
4ffbba8
Set CC=clang for Windows
Steelskin Aug 7, 2024
8604c04
Add diagnostic message
Steelskin Aug 7, 2024
c5e77df
Set build compiler to clang-cl
Steelskin Aug 7, 2024
f831f5d
Reset env variables
Steelskin Aug 7, 2024
1b995d4
More diagnostic log
Steelskin Aug 7, 2024
52646fd
Use the old way of setting toolchains
Steelskin Aug 7, 2024
12d5315
HACK: Dump environment
Steelskin Aug 7, 2024
1e163d1
Use lower or upper case variants of env variables
Steelskin Aug 7, 2024
1bbc082
Re-add clang-cl toolchain build arg
Steelskin Aug 7, 2024
0af2609
Add BAZEL_LLVM variable
Steelskin Aug 7, 2024
2835f78
Invert Parth <-> PATH
Steelskin Aug 7, 2024
26b3710
Add "--repo_env" for env variables
Steelskin Aug 7, 2024
17d91ff
Add CC env variable
Steelskin Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add CC env variable
@Steelskin
Steelskin committed Aug 7, 2024
commit 17d91fff2a585f0a1059bcdc76dbdae764359f72
5 changes: 1 addition & 4 deletions .bazelci/presubmit.yml
View file
Original file line number Diff line number Diff line change
@@ -40,6 +40,7 @@ x_defaults:
platform: windows
environment:
SWIFT_VERSION: 0.0.0
CC: "clang-cl"
PATH: "%LOCALAPPDATA%\\Programs\\Swift\\Toolchains\\%SWIFT_VERSION%+Asserts\\usr\\bin;%LOCALAPPDATA%\\Programs\\Swift\\Runtimes\\%SWIFT_VERSION%\\usr\\bin;%PATH%"
SDKROOT: "%LOCALAPPDATA%\\Programs\\Swift\\Platforms\\%SWIFT_VERSION%\\Windows.platform\\Developer\\SDKs\\Windows.sdk"
BAZEL_LLVM: "%LOCALAPPDATA%\\Programs\\Swift\\Toolchains\\%SWIFT_VERSION%+Asserts\\usr"
@@ -50,10 +51,6 @@ x_defaults:
- "--compiler=clang-cl"
# TODO: Use the new way of setting toolchains.
- "--noincompatible_enable_cc_toolchain_resolution"
- "--repo_env=CC=clang-cl"
- "--repo_env=BAZEL_LLVM=${{ env.BAZEL_LLVM }}"
- "--repo_env=SDKROOT=${{ env.SDKROOT }}"
- "--repo_env=Path=${{ env.PATH }}"
build_targets:
- "//tools/..."
test_flags: