Introduce a pure Swift runfiles library #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cerisier
force-pushed
the
runfiles_library
branch
from
4e8b878 to
adda967
Compare
cerisier
force-pushed
the
runfiles_library
branch
from
adda967 to
6518806
Compare
cerisier
force-pushed
the
runfiles_library
branch
from
6518806 to
ca0cd32
Compare
fmeum
reviewed
Sep 19, 2024
Co-authored-by: Luis Padron <heyluispadron@gmail.com>
Co-authored-by: Luis Padron <heyluispadron@gmail.com>
Co-authored-by: Luis Padron <heyluispadron@gmail.com>
Co-authored-by: Luis Padron <heyluispadron@gmail.com>
luispadron
approved these changes
Jan 28, 2025
fmeum
approved these changes
Jan 29, 2025
Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
brentleyjones
approved these changes
Feb 24, 2025
Co-authored-by: Brentley Jones <github@brentleyjones.com>
Co-authored-by: Brentley Jones <github@brentleyjones.com>
|
@luispadron up to date ! |
|
Enabled auto-merge, thanks for all your work on this. When I'm back at my computer I'll try to get this into a 2.x release |
luispadron
added a commit
that referenced
this pull request
Mar 4, 2025
Fixes #890 # Main implementation I followed guidance from @fmeum and based this implementation on the runfiles library of `rules_python` where applicable since this was pointed as the reference implementation. In addition to `rules_python` implementation, this implementation uses a similar mechanism as the C++ implementation for deducing the `RUNFILES_DIR` and `RUNFILES_MANIFEST_FILE` location based on `argv0`. --------- Co-authored-by: Brentley Jones <github@brentleyjones.com> Co-authored-by: Luis Padron <heyluispadron@gmail.com> Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
luispadron
added a commit
that referenced
this pull request
Mar 4, 2025
Fixes #890 # Main implementation I followed guidance from @fmeum and based this implementation on the runfiles library of `rules_python` where applicable since this was pointed as the reference implementation. In addition to `rules_python` implementation, this implementation uses a similar mechanism as the C++ implementation for deducing the `RUNFILES_DIR` and `RUNFILES_MANIFEST_FILE` location based on `argv0`. --------- Co-authored-by: Brentley Jones <github@brentleyjones.com> Co-authored-by: Luis Padron <heyluispadron@gmail.com> Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
luispadron
added a commit
that referenced
this pull request
Mar 8, 2025
Fixes #890 I followed guidance from @fmeum and based this implementation on the runfiles library of `rules_python` where applicable since this was pointed as the reference implementation. In addition to `rules_python` implementation, this implementation uses a similar mechanism as the C++ implementation for deducing the `RUNFILES_DIR` and `RUNFILES_MANIFEST_FILE` location based on `argv0`. --------- Co-authored-by: Brentley Jones <github@brentleyjones.com> Co-authored-by: Luis Padron <heyluispadron@gmail.com> Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First shot at implementing #890
Main implementation
I followed guidance from @fmeum and based this implementation on the runfiles library of
rules_pythonwhere applicable since this was pointed as the reference implementation.In addition to
rules_pythonimplementation, this implementation uses a similar mechanism as the C++ implementation for deducing theRUNFILES_DIRandRUNFILES_MANIFEST_FILElocation based onargv0.TODO