Map const-values in output file map for incremental #1471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we extracting
swiftconstvalues
from #1170But we forgot to update the path for swiftconstvalues in the incremental output file map.
It leads to the incremental feature not working.
For example, demo: https://github.com/vikage/DemoBazelSwiftIncremental
When I change file B.swift (No other file uses struct B) but log shows build A.swift and C.swift as well
I used
-driver-show-job-lifecycle
and-driver-show-incremental
flags to show debug logThese are logs after fix. As you can see, only B.swift will be compile
The solution here should be to remap swiftconstvalues path to
_swift_incremental
directoryRelated issue: #1291