Support additional_linker_inputs in swift_binary
#1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adincebic
requested review from
aaronsky,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
adincebic
force-pushed
the
adin/implement-additiona_linker_inputs-attr
branch
from
5e49b82 to
ac269f8
Compare
swift/swift_binary.bzl
Outdated
| ctx, | ||
| ctx.attr.linkopts, | ||
| ctx.attr.swiftc_inputs, | ||
| ctx.attr.swiftc_inputs + ctx.attr.additional_linker_inputs, |
There was a problem hiding this comment.
I think we want to remove swiftc_inputs here?
| expected_inputs = ctx.attr.expected_additional_inputs | ||
| expected_linkopts = ctx.attr.expected_linkopts | ||
|
|
||
| action_input_paths = set([input.short_path for input in link_action.inputs.to_list()]) |
There was a problem hiding this comment.
Looks like we can't use set yet in our tests, since they run on Bazel 7.
swift/swift_binary.bzl
Outdated
| create_linking_context_from_compilation_outputs( | ||
| actions = ctx.actions, | ||
| additional_inputs = ctx.files.swiftc_inputs, | ||
| additional_inputs = ctx.files.swiftc_inputs + ctx.files.additional_linker_inputs, |
There was a problem hiding this comment.
I think we want to remove swiftc_inputs here?
|
@brentleyjones I updated the PR. I left |
brentleyjones
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
While this is technically a breaking change, in a way that could be hard to fix in non-root modules, it doesn't look like any public modules was using swiftc_inputs for linker inputs. So I'm fine with this if @keith is.
|
sure, i like naming matching other rules |
adincebic
force-pushed
the
adin/implement-additiona_linker_inputs-attr
branch
from
064b690 to
6f43932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1511