Add ci.yaml for github workflows #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jylinv0
force-pushed
the
workflow
branch
3 times, most recently
from
d0f860f to
86e38fd
Compare
mithriltabby
reviewed
Feb 6, 2024
| @@ -34,6 +34,9 @@ SED_SCRIPT=${TEST_TMPDIR}/runner_config.sed | |||
| # enums. | |||
| echo 's#\\*\"@!([^!]+)!@\\*\"#\1#g' > ${SED_SCRIPT} | |||
|
|
|||
| unset rlocation | |||
| unset is_absolute | |||
There was a problem hiding this comment.
They're functions that created by bazel during test. The generation of sed script doesn't take care of function, so the script will be formatted incorrectly. The proper fix would be explicitly name which env vars to print in printenv or somehow handle functions properly during the generation.
There was a problem hiding this comment.
Add a comment explaining this, or adjust the grep expression used to remove lines from the printenv output and add the comment there. It'd be very difficult to know ahead of time exactly which environment variables we want to expand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instrumentation test to github workflow