Skip to content

Commit

Permalink
Remove deprecated data cfg transition. (#270)
Browse files Browse the repository at this point in the history
  • Loading branch information
DrMarcII authored and joshbruning committed Jul 11, 2018
1 parent 7ffe970 commit 9200b9e
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 10 deletions.
4 changes: 2 additions & 2 deletions go/webtest/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ go_web_test_suite(
},
"//browsers/sauce:chrome-win10-connect": {
"tags": ["sauce"],
},
},
},
browsers = [
"//browsers:chrome-external",
"//browsers:chromium-local",
"//browsers:firefox-local",
"//browsers/sauce:chrome-win10",
"//browsers/sauce:chrome-win10-connect",
"//browsers/sauce:chrome-win10-connect",
],
data = ["//testdata"],
embed = [":go_default_library"],
Expand Down
4 changes: 2 additions & 2 deletions testing/web/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ py_web_test_suite(
},
"//browsers/sauce:chrome-win10-connect": {
"tags": ["sauce"],
},
},
},
browsers = [
"//browsers:chromium-local",
"//browsers:firefox-local",
"//browsers/sauce:chrome-win10",
"//browsers/sauce:chrome-win10-connect",
"//browsers/sauce:chrome-win10-connect",
],
srcs_version = "PY2AND3",
deps = [":web"],
Expand Down
1 change: 0 additions & 1 deletion web/internal/browser.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ browser = rule(
"data": attr.label_list(
doc = "Runtime dependencies for this configuration.",
allow_files = True,
cfg = "data",
),
"deps": attr.label_list(
doc = "Other web_test-related rules that this rule depends on.",
Expand Down
1 change: 0 additions & 1 deletion web/internal/web_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ web_test = rule(
"data": attr.label_list(
doc = "Additional runtime dependencies for the test.",
allow_files = True,
cfg = "data",
),
"launcher": attr.label(
doc = "The web test launcher binary.",
Expand Down
1 change: 0 additions & 1 deletion web/internal/web_test_config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ web_test_config = rule(
"data": attr.label_list(
doc = "Runtime dependencies for this configuration.",
allow_files = True,
cfg = "data",
),
"deps": attr.label_list(
doc = "Other web_test-related rules that this rule depends on.",
Expand Down
6 changes: 3 additions & 3 deletions web/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -421,17 +421,17 @@ def org_chromium_chromium():
amd64_sha256 =
"665f3ec731ea93ca4d4593cd9ab7095634dd89b7e332d92bb7722f3f1a59e0f7",
amd64_urls = [
"https://commondatastorage.googleapis.com/chromium-browser-snapshots/Linux_x64/573780/chrome-linux.zip"
"https://commondatastorage.googleapis.com/chromium-browser-snapshots/Linux_x64/573780/chrome-linux.zip",
],
macos_sha256 =
"029e4647ea579c0df38e770bd47a5c229723580b7c655fcf2bffb909dfb19e29",
macos_urls = [
"https://commondatastorage.googleapis.com/chromium-browser-snapshots/Mac/573760/chrome-mac.zip"
"https://commondatastorage.googleapis.com/chromium-browser-snapshots/Mac/573760/chrome-mac.zip",
],
windows_sha256 =
"59d1464c11c1d84d3c8941fe1a3a828771382c997b57be1039d8cdc0911f3ce2",
windows_urls = [
"https://commondatastorage.googleapis.com/chromium-browser-snapshots/Win_x64/573768/chrome-win32.zip"
"https://commondatastorage.googleapis.com/chromium-browser-snapshots/Win_x64/573768/chrome-win32.zip",
],
)

Expand Down

0 comments on commit 9200b9e

Please sign in to comment.