Skip to content

Commit

Permalink
Make lint pass
Browse files Browse the repository at this point in the history
  • Loading branch information
nigelmegitt committed Jul 15, 2024
1 parent 8c764d9 commit 0c7a41a
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 21 deletions.
5 changes: 4 additions & 1 deletion .eslintrc.js → .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ module.exports = {

"no-console": "off",

"sourceType": "module"
"comma-dangle": [
"error", "always-multiline"
],
// "sourceType": "module"

// "max-statements": ["error", 30]

Expand Down
2 changes: 1 addition & 1 deletion src/AdNode.es6
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default class AdNode {
this.parent = parent;
this.time = {
begin: TimingCalculator.computeBegin(xmlNode),
end: undefined
end: undefined,
};

this._name = xmlNode.name;
Expand Down
2 changes: 1 addition & 1 deletion src/AdSourceNode.es6
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const readyStateMap = {
1: "HAVE_METADATA",
2: "HAVE_CURRENT_DATA",
3: "HAVE_FUTURE_DATA",
4: "HAVE_ENOUGH_DATA"
4: "HAVE_ENOUGH_DATA",
};

// This guy is a little weird - It's the input to it's parent; i.e. in the graph
Expand Down
8 changes: 4 additions & 4 deletions src/Parser.es6
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,9 @@ export default function parseTree(audioContext, media, url, xmlTree, startRoot)
namespaces: {
default: Utils.NS_TTML_URI,
xml: Utils.NS_XML_URI,
tta: `${Utils.NS_TTML_AUDIO_URI}`
tta: `${Utils.NS_TTML_AUDIO_URI}`,
},
fullyQualifiedName: `${Utils.NS_TTML_URI}%%tt`
fullyQualifiedName: `${Utils.NS_TTML_URI}%%tt`,
},
audioContext,
mediaPair);
Expand All @@ -352,9 +352,9 @@ export default function parseTree(audioContext, media, url, xmlTree, startRoot)
name: "default audio out",
attributes: {},
namespaces: {
xml: Utils.NS_XML_URI
xml: Utils.NS_XML_URI,
},
fullyQualifiedName: ""
fullyQualifiedName: "",
},
audioContext);
defaultOutput.makeDefaultOutput();
Expand Down
28 changes: 14 additions & 14 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,26 +26,26 @@ export default {
],
mode: "development",
entry: [
"./src/index.es6"
"./src/index.es6",
],
plugins: [
new CircularDependencyPlugin({
// `onStart` is called before the cycle detection starts
onStart({ compilation }) {
console.log('start detecting webpack modules cycles');
onStart() {
console.log("start detecting webpack modules cycles");
},
// `onDetected` is called for each module that is cyclical
onDetected({ module: webpackModuleRecord, paths, compilation }) {
onDetected({ paths, compilation }) {
// `paths` will be an Array of the relative module paths that make up the cycle
// `module` will be the module record generated by webpack that caused the cycle
compilation.errors.push(new Error(paths.join(' -> ')))
compilation.errors.push(new Error(paths.join(" -> ")));
},
// `onEnd` is called before the cycle detection ends
onEnd({ compilation }) {
console.log('end detecting webpack modules cycles');
onEnd() {
console.log("end detecting webpack modules cycles");
},
cwd: process.cwd(),
})
}),
],
experiments: {
outputModule: true,
Expand All @@ -55,20 +55,20 @@ export default {
filename: "./bin/js/bundle.js",
library: {
type: "module",
}
},
},
devServer: {
contentBase: "./dist",
index: "index.html",
watchContentBase: true
watchContentBase: true,
},
module: {
rules: [
{
test: /\.(es6|js)$/,
exclude: /node_modules/,
loader: "babel-loader"
}
]
}
loader: "babel-loader",
},
],
},
};

0 comments on commit 0c7a41a

Please sign in to comment.